Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Next.js][React] Link component does not add anchor to the internal links #1226

Merged
merged 5 commits into from
Nov 2, 2022
Merged

[Next.js][React] Link component does not add anchor to the internal links #1226

merged 5 commits into from
Nov 2, 2022

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Nov 2, 2022 •
edited
Loading

Description / Motivation

Add support for anchor attribute for:

  • sitecore-jss-react
  • sitecore-jss-nextjs

Pulled nextjs part from #1220

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team November 2, 2022 08:08
@ambrauer ambrauer mentioned this pull request Nov 2, 2022
Merged
1 task
ambrauer
ambrauer approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ambrauer ambrauer merged commit 3dcf5a1 into dev Nov 2, 2022
@ambrauer ambrauer deleted the bugfix/555043 branch November 2, 2022 16:05
@ambrauer ambrauer mentioned this pull request Nov 2, 2022
Closed
3 tasks
illiakovalenko added a commit that referenced this pull request Jan 18, 2024
@illiakovalenko
[Next.js][React] Link component does not add anchor to the internal l…
f447429 
…inks (#1226)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzi pzi pzi left review comments

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@illiakovalenko @ambrauer @pzi