Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[templates/nextjs] Add healthz check #1207

Merged
merged 5 commits into from
Nov 3, 2022
Merged

[templates/nextjs] Add healthz check #1207

merged 5 commits into from
Nov 3, 2022

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Oct 20, 2022 •
edited
Loading

Description / Motivation

  • Introduce /healthz API route, which will be used by XMCloud container editing host.

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team October 20, 2022 10:06
ambrauer
ambrauer suggested changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, see some comments

packages/create-sitecore-jss/src/templates/nextjs/src/pages/api/healthz.ts Outdated Show resolved Hide resolved
packages/sitecore-jss-nextjs/src/editing/editing-healthz-middleware.ts Outdated Show resolved Hide resolved
packages/sitecore-jss-nextjs/src/editing/editing-healthz-middleware.ts Outdated Show resolved Hide resolved
packages/sitecore-jss-nextjs/src/editing/editing-healthz-middleware.ts Outdated Show resolved Hide resolved
ambrauer
ambrauer approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the new submodule to doc generation. Otherwise, looks good!

@illiakovalenko illiakovalenko merged commit ed8b6e7 into dev Nov 3, 2022
@illiakovalenko illiakovalenko deleted the feature/552134 branch November 3, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KKings KKings KKings left review comments

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@illiakovalenko @ambrauer @KKings