[sitecore-jss] rootItemId not resolvable for different language versions
#1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addy-pathania
changed the title
rootItemId not resolvable for different language versions
ambrauer
suggested changes
Oct 10, 2022
There was a problem hiding this comment.
See comments. Also, please add unit tests for this new case.
ambrauer
reviewed
Oct 13, 2022
ambrauer
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dictionary service doesn't return
rootItemIdfor other language versions other than English.Added a fix to make another request using language as
ento get therootItemIdas it is same in all versions.Description / Motivation
Testing Details
Types of changes