Update dependencies #118
Merged
Update dependencies #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update from es5 to es2015 (remove bluebird) * migrate from tsd typings to @types * update Intern from 3 to 4 * remove obsolete TSLint rules * fix lint/syntax issues
dylans
approved these changes
Nov 28, 2018
package.json
Outdated
| "test": "tests/run.sh" | ||
| "@types/glob": "^7.1.1", | ||
| "@types/mkdirp": "^0.5.2", | ||
| "dojo-loader": "^2.0.0-beta.7", |
There was a problem hiding this comment.
Do we still need the loader? I’m guessing we never released a non-beta version?
There was a problem hiding this comment.
Build and tests run fine without dojo-loader; I removed it now.
|
Need to determine why Travis is failing, but overall looks like some much needed changes. Thanks! |
|
Looks like Travis for this may be running a very old version of Node.js still (4.1...) |
dylans
suggested changes
Nov 28, 2018
There was a problem hiding this comment.
Ok, I think to get this to pass with Travis, we need to also update https://github.com/SitePen/dts-generator/blob/master/.travis.yml#L4 ... probably 8.14.0 since that's still in LTS, though we could force 10.14.0 since that's also in LTS if that's necessary.
dylans
approved these changes
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the version in package.json to 3.0.0-alpha since this is a breaking change - the compile target is now es2015, so it must be run in an environment that supports es2015 (or be transpiled and shimmed). Intern 4 appears to depend on es2015 and promises with bluebird were causing compilation problems. If we want to retain es5 as the compile target we'll have to address those issues.