Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] account_receipt_base: Report, Partner, Fiscal Position #2

Conversation

SirTakobi
Copy link
Owner

To be included in OCA#1427

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023

Codecov Report

❗ No coverage uploaded for pull request base (14.0-add-account_receipt_base@6d91725). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                       Coverage Diff                        @@
##             14.0-add-account_receipt_base       #2   +/-   ##
================================================================
  Coverage                                 ?   95.10%           
================================================================
  Files                                    ?      408           
  Lines                                    ?     6828           
  Branches                                 ?      937           
================================================================
  Hits                                     ?     6494           
  Misses                                   ?      199           
  Partials                                 ?      135           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

options="{'currency_field': 'currency_id'}"
/>
</span>
<span class="o_stat_text">Invoiced Receipts</span>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use only "Receipts", as they are not invoices

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@SirTakobi SirTakobi force-pushed the 14.0-imp-account_receipt_base-report_partner_fiscal_position branch from ed95b15 to f4ff2e3 Compare March 30, 2023 15:59
@SirTakobi SirTakobi requested a review from eLBati March 30, 2023 16:04
Copy link

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SirTakobi SirTakobi merged commit cc79d0a into 14.0-add-account_receipt_base Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants