Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add portability testing and continuous integration using Sage #1018

Merged
merged 17 commits into from
Feb 16, 2021

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jul 6, 2020

No description provided.

@fingolfin
Copy link
Contributor

Note: I started working on PR #1019 on July 3, so it is not a reaction to this PR (in fact I only saw this PR just now :-). The two PRs complement each other.

The advantage of "my" PR is that a CI run takes 10-15 minutes to complete, while for this PR here, CI runs are more like 8 hours.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 8, 2020

Great. The more CI, the merrier. And indeed, they complement each other. Your continuous testing run on #1019 is suitable to run on every commit. The continuous integration workflow on this PR is configured to run only on tags and pull requests. I would hope that the Singular project will find it valuable when preparing new releases, or making major configuration changes. I'll be happy to help with making necessary adjustments or explaining details.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 24, 2020

A run with the updated workflow can be seen at https://github.com/mkoeppe/Sources/actions/runs/181585170

@hannes14 hannes14 merged commit 88dd7f0 into Singular:spielwiese Feb 16, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 18, 2021

Thanks for merging this. I'll send you a follow-up PR that will reflect recent changes in Sage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants