Cards of color pickers #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent, thanks, @tupui! This way is even better. Can we set the default colors as these? I think the main branch and .io are fine. |
gnopik
approved these changes
Oct 17, 2023
Closed
|
Oh thanks! In it goes then and opening a followup for the start colors. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One caveat is that by default the colormap is slightly changed. This is because I am calculating a colormap using a single color to get this working. The resulting colormap per group is a linear variation of the luminance channel.
@gnopik if you want to test a live version, I could make another testing deployment in the same project. I think if we do this, I would not link it to the domain (e.g. dev.simdec.io). I think I read that Cloud Run has issues with automatically handling subdomains. But I can always try and see.
This is how it looks: