Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #261 of 0√ #267

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Fixed issue #261 of 0√ #267

merged 1 commit into from
Jul 4, 2022

Conversation

rsb-23
Copy link
Contributor

@rsb-23 rsb-23 commented Jul 3, 2022

Cause :
lastKey was not updated when newValue became null on clear C.
Hence lastKey validation at line 95 if (lastKey != DIGIT) { failed.
Fix :
lastKey should be CLEAR , whenever newValue becomes null or 0 after C.

TestCases:

  1. Start calc > C >
  2. Hold C > 5*0 > + > C >

Cause : lastKey was not updated when newValue became "". Hence lastKey validation at line 95 failed.
@tibbi
Copy link
Contributor

tibbi commented Jul 4, 2022

ye thanks, this looks good

@tibbi tibbi merged commit 7e33f9a into SimpleMobileTools:master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants