Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Generalize handling of contractions like "'d", "'s" or "'th" #42

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

jcfr
Copy link
Contributor

@jcfr jcfr commented Jul 11, 2023

Systematically strip the contraction from the error word before performing additional checks.

This pull request has the following purposes:

  • update the naming from possessive to the more general terminology called contraction
  • add support for additional contractions
  • systematically strip the known contraction before doing any error checking and accept the updated word if associated spell check succeeds after removing the contraction.

Systematically strip the contraction from the error word before performing
additional checks.
@jcfr jcfr force-pushed the generalize-contraction-support branch from 40c8fbb to 4fcf562 Compare July 11, 2023 00:19
@jcfr
Copy link
Contributor Author

jcfr commented Jul 11, 2023

Thanks for the review 🙏

@dave3d dave3d merged commit 65d081a into SimpleITK:main Jul 11, 2023
@jcfr jcfr deleted the generalize-contraction-support branch July 11, 2023 00:24
@jcfr jcfr mentioned this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants