New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MinBy/MaxBy Null Handling #241

Merged

SimonCropp merged 3 commits into SimonCropp:main from dahlbyk:min-max

Oct 25, 2024

Contributor

dahlbyk commented Oct 25, 2024

Noticed #50 doesn't handle null like net9.0, confirmed by tests in the first commit.

null values are neither min nor max unless all values are null
Empty sources return null for nullable types, but throw instead of returning default for non-nullable value types

dahlbyk added 3 commits

October 25, 2024 00:08


          More Min/Max tests

5d6e399


          Param is source

17fb09d


          Fix min/max null handling

ed642d9

Owner

SimonCropp commented Oct 25, 2024

thanks. will deploy now

SimonCropp merged commit bf7853e into SimonCropp:main

2 checks passed

SimonCropp added this to the 7.1.1 milestone

dahlbyk deleted the min-max branch

October 25, 2024 14:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet