Fix some compiler errors that can occur with specific project setups (Memory references) #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing Polyfill in a few different projects, I hit a few compiler errors which this PR attempts to resolve.
First, in a
netstandard2.0
project that referencesSystem.Threading.Tasks.Extensions
but doesn't referenceSystem.Memory
, I saw the following errors:This was fixed in this PR by adding the
MEMORYREFERENCED
define in a few extra places.Then, in another project that defined its ownDebug
class, I saw the following errors:This was solved by adding some explicitusing Debug = System.Diagnostics.Debug;
lines in Polyfill.EDIT: Second issue/fix extracted into separate PR #122.