Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof reading always runs and has unintended(?) behavior #152

Open
LemonIllusion opened this issue Nov 3, 2020 · 3 comments
Open

Proof reading always runs and has unintended(?) behavior #152

LemonIllusion opened this issue Nov 3, 2020 · 3 comments
Labels

Comments

@LemonIllusion
Copy link
Contributor

  1. The DOM changes by proof reading causes different styling (font, capitalization) for article headings (and more?).
  2. There is no way to prevent this because the condition for the operation is too lenient and does not care about the setting for proofreading articles.
    Here's a screenshot of with/without (left/right) BSC running:

    In the block below, isReadingEditorialContent should probably be along the lines of (isReadingEditorialContent && Preferences.get(P.advanced._.proofread_articles) !== Proofreading.Options.NEVER). Or I'm in the wrong bit of code altogether. I've not verified anything.
    operation({
        description: "perform proofreading processing",
        condition: () => isReadingEditorialContent || (isInEditMode && Preferences.get(P.advanced._.proofread_forum_posts)),
        action: Proofreading.performProcessing,
        deferUntil: DOMCONTENTLOADED,
    }),
@SimonAlling
Copy link
Owner

Nice catch! I'm on it.

@SimonAlling
Copy link
Owner

Note to self: related to and perhaps semi-blocked by the planned incorporation of @alling/better-sweclockers-lib into Better SweClockers. Hotfix needed though; this is not acceptable.

@SimonAlling SimonAlling added the bug label Nov 4, 2020
SimonAlling added a commit that referenced this issue Nov 4, 2020
This is a hotfix for #152.

Headings were incorrectly made uppercase by our proofreading processing
in combination with SweClockers' stylesheet.
@SimonAlling
Copy link
Owner

Will keep this open so I don't forget about it.

SimonAlling added a commit that referenced this issue Nov 4, 2020
This is a hotfix for #152.

Headings were incorrectly made uppercase by our proofreading processing
in combination with SweClockers' stylesheet.

I think we should aim for a better solution once we've incorporated `better-sweclockers-lib` into Better SweClockers.
SimonAlling added a commit that referenced this issue Nov 15, 2020
This fixes the problem described in point 2 in #152.
SimonAlling added a commit that referenced this issue Nov 15, 2020
This fixes the problem described in point 2 in #152.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants