Clean up code 59 #67
Clean up code 59 #67
Conversation
…tributions struct.
|
@mrp089 Yes, it looks odd. Shall I close this and merge from the command line? |
|
@ktbolt, yeah, that's probably easier. I think the build error is just some variable naming. |
|
You can still keep this pull request open. Whatever you commit to this branch will automatically show up here. |
| std::cout << "[svzerodsolver] Error: Parsing the input file '" << input_file_name << "' has failed." << std::endl; | ||
| std::cout << "[svzerodsolver] Details of the parsing error: " << std::endl; | ||
| std::cout << e.what() << std::endl; | ||
| return 1; |
There was a problem hiding this comment.
I appreciate all the error handling! Why do we never throw an actual error?
| @@ -96,7 +96,7 @@ class SparseSystem { | |||
| * | |||
| * @param n Size of the system | |||
| */ | |||
| SparseSystem(unsigned int n); | |||
| SparseSystem(int n); | |||
There was a problem hiding this comment.
Why did you remove a couple of unsigned?
There was a problem hiding this comment.
Unsigned int's are really only used when doing something with bit values. If you set an unsigned int to a negative value then you get garbage.
You can argue that it can be self-documenting, that n should be >= 0. But isn't it better to actually use a better name such as system_size that documents what it is rather than n?
| @@ -61,34 +61,32 @@ extern "C" void initialize(std::string input_file, int& problem_id, | |||
| std::vector<std::string>& block_names, | |||
| std::vector<std::string>& variable_names); | |||
|
|
|||
| extern "C" void set_external_step_size(const int problem_id, | |||
| extern "C" void set_external_step_size(int problem_id, | |||
There was a problem hiding this comment.
Why did you remove a couple of const?
There was a problem hiding this comment.
An int is passed by value so you don't need to const qualify it, doesn't make a difference to the caller.
These are some code clean cleaning changes I made for #59.
Most of these are simple changes.
I also added improved error checking in the applications
mainfunction.