-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solid material model testing framework #225
Merged
MatteoSalvador
merged 17 commits into
SimVascular:main
from
aabrown100-git:material_unit_tests
Jul 22, 2024
Merged
Solid material model testing framework #225
MatteoSalvador
merged 17 commits into
SimVascular:main
from
aabrown100-git:material_unit_tests
Jul 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e test names more descriptive
…o undefined behavior.
…finite difference S_ref
Create s orthogonal to f. Use F = I + random. Add flag for HO with/without full anisotropic invariants
MatteoSalvador
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice job @aabrown100-git! This looks good to me
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current situation
Currently, solid material models (in the function
get_pk2cc()
) are tested only through full simulations. It's difficult to tell from simulation results if the material models are implemented correctly, and there are likely some bugs inget_pk2cc()
. See additional discussion in issue #150Release Notes
mat_fun_carray.h
mat_models_carray.h
) and in reading Mooney-Rivlin parameters (seeset_material_props.h
)Documentation
I have included instructions in
test.h
for adding material models to the testing suite.Testing
Please ensure that the PR meets the testing requirements set by GitHub Actions.
The code itself is testing.
Code of Conduct & Contributing Guidelines