Trilinos and PETSc interfaces (#30) and Docker containers (#211) #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imVascular#211) - Trilinos and PETSc interfaces added by @ktbolt - created dockerfiles to build Docker containers with pre-compiled Trilinos and PETSc libraries in Ubuntu-20.04 and Ubuntu-22.04 - added test cases for fluid and fsi problems to test Trilinos and PETSc linear solvers and preconditioners - updated the workflow file test_ubuntu.yml to include PETSc and Trilinos tests for continuous integration (CI)
MatteoSalvador
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Thanks @dcodoni, really nice work! I am very happy to see that this PR is finally ready to be merged.
aabrown100-git
added a commit
to aabrown100-git/svMultiPhysics
that referenced
this pull request
Aug 20, 2024
1 task
ktbolt
pushed a commit
that referenced
this pull request
Aug 21, 2024
#240) * Replace fsi_ls_upd() call that was mistakenly removed in #216. Also, call it if mvMsh is true, which I think is necessary for FSI sims. This improves nonlinear convergence in 0D-coupled struct/ustruct test cases. * For struct/LV_NeoHookean_passive_sv0D, increase max iteration, update ref solution. Previous ref solution was not converged, so need to update now that we are converging * Switch Nx.slice(g) to Nx.rslice(g) (avoids copying data)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of PETSc and Trilinos interfaces
Current situation
The current svFSIplus does not include interfaces for PETSc and Trilinos.
Release Notes
The following features were added in this pull request:
fluid/: pipe_RCR_3d_petsc/ pipe_RCR_3d_ilut_trilinos/ pipe_RCR_3d_bj_trilinos/
fsi/: pipe_3d_petsc/ pipe_3d_ml_trilinos/ pipe_3d_bj_trilinos
Documentation
More information about the docker containers created refer to the following link:
https://hub.docker.com/repository/docker/dcodoni/lib/general
Testing
All the tests ran successfully. The tests for PETSc and Trilinos were only run on Ubuntu, while MacOS skipped these tests.
Code of Conduct & Contributing Guidelines