No warnings, added tests, added viewBox option

[nkezhaya]

No description provided.

[siliconavengers]

Thanks for the PR. I do agree that the options should be keyword list instead of map. However, existing user might still be using map as the options. I have tried that using map as an options will break the SVG generation due to the following code in svg.ex:

dimension_attrs =
      if Keyword.get(options, :viewbox, false) do
        ~s(viewBox="0 0 #{dimension} #{dimension}")
      else
        ~s(width="#{dimension}" height="#{dimension}")
      end

Can we still continue to support using map as options and add a deprecation warning or fix the above code to allow reading from map instead?

[nkezhaya]

@siliconavengers Fixed.

[siliconavengers]

@whitepaperclip Thanks. Will merge and update the hex package soon.