Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silky/Magnetic appear to not be functioning #697

Open
MikeyM3thodic4l opened this issue Oct 6, 2024 · 5 comments
Open

Silky/Magnetic appear to not be functioning #697

MikeyM3thodic4l opened this issue Oct 6, 2024 · 5 comments
Labels
1.21 bug Something isn't working

Comments

@MikeyM3thodic4l
Copy link

Versions

  • Silent Gear: 4.0.2
  • Silent Lib: 10.3.0
  • Forge: NeoForge 21.1.65
  • Optifine Installed: No

Apologies if this is already known (didn't see it listed on any of the releases but I am aware there are quite a few bugs you're hammering out on this release still) but in the half hour of me playing the release I've encountered that both Silky and Magnetic both are being applied to parts/tools correctly, but appear to not be functional. This seems to be true both when applied as a main material as well as from optional parts being applied to the tool.

Also while trying to troubleshoot/test this locally I also noticed that the gear toolkit does not have the ability to remove tips although they can still be swapped for other tips in the crafting grid.

@MikeyM3thodic4l MikeyM3thodic4l added the bug Something isn't working label Oct 6, 2024
@SilentChaos512
Copy link
Owner

I was aware of these, but thank you for making an issue for it.

To explain, I skipped over enchantment traits because I haven't figured out how to update them just yet. And with Magnetic, I think I just forgot about it. I was planning to make some changes to it.

@bastetfurry
Copy link

bastetfurry commented Oct 23, 2024

Don't know if related but bracelet attack damage isn't added to weaponry either unless that is intentional.
Tested that on a Dummy with bracelets on and off and there was no difference in dealt damage.

Reach on a bracelet doesn't work either, unless that isn't for weapons. Only armor works somewhat as intended and there only one armor +1 from one bracelet is taken into account.

Modpack is ATM10 1.5 by the way with Silent Gear 4.0.6 and Silent Lib 10.3.0 respectively.

@max0n4ik
Copy link

Don't know if related but bracelet attack damage isn't added to weaponry either unless that is intentional. Tested that on a Dummy with bracelets on and off and there was no difference in dealt damage.

Reach on a bracelet doesn't work either, unless that isn't for weapons. Only armor works somewhat as intended and there only one armor +1 from one bracelet is taken into account.

Modpack is ATM10 1.5 by the way with Silent Gear 4.0.6 and Silent Lib 10.3.0 respectively.

I confirm that it does not work on atm10 either

@HyenaGames
Copy link

A Note, it also appears that Silent Gear Arrow don't work right. I assume those arrows use a trait to make them not actually fire the arrow, and that's broken.

Expected:
You craft a SilentGear arrow and fire it from a SilentGear bow and it uses up durability/ammo on the arrow but doesn't actually remove that arrow from your inventory.

What happens as of 11/13/24: The single arrow with Ammo:64 or Ammo:256 or whatever as durability gets fired out of your inventory and can't be used again unless you run and pick it up.

If I need to make a separate Issue on this let me know!

@SilentChaos512
Copy link
Owner

@HyenaGames That is completely unrelated, and there is already an open issue (#730)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants