Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VN Factions Face and Voice changes #85

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

Androkiller
Copy link

@Androkiller Androkiller commented Nov 29, 2023

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Information:
Faces for VN Reb Factions where not Asian thus has been changed.

Voice VIE is a muted voice, no calls are made. This voice is need for the Ambient sound module in S.O.G which is not present for the mission. I have therefore changed to the next best thing available Chinese

Please specify which Issue this PR Resolves.

N/A

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps:
Recruit AI and now they make calls in Chinese when given commands or reporting


Notes:
Antistasi the Mod, also has the same issue, so could be changed to VIE if they implement the ambient module, however this is not for for Radio reports but only proximity based to enemy units.

changed face and voice matching VN_AI_ARVN.sqf
changed identiry section so matches VN_AI_ARVN.sqf
@stutpip123
Copy link
Collaborator

the module cannot be implemented because would create a permanent SOGPF dependancy (could be done for SOGPF maps only i suppose)

@stutpip123
Copy link
Collaborator

changes look fine to me

@Androkiller
Copy link
Author

Androkiller commented Nov 29, 2023

the module cannot be implemented because would create a permanent SOGPF dependancy (could be done for SOGPF maps only i suppose)

haven't quite worked out the best way to implement, but i would assume under the mission sqm for both VN maps. looks like the module requires just to be present, but its not quite the same as call outs just ambient sound when in proximity.

@Androkiller
Copy link
Author

So editing the mission with the module present results in the module not working. This is due to the module is reliant on the actual units being part of the faction are present, as in the unit class name needs to be present from the correct faction.
Due to how antistasi creates units from templates the correct unit class names are not present. Hence the module will not work and would require an additional mod ontop to make it work.
So looks like Chinese is the closest one will get when playing antistasi.

@SilenceIsFatto
Copy link
Owner

SilenceIsFatto commented Dec 7, 2023

I'll test this at some point and see if all is good. Is there anything else you want to add?

@SilenceIsFatto SilenceIsFatto merged commit 81dc36a into SilenceIsFatto:unstable Dec 14, 2023
@SilenceIsFatto
Copy link
Owner

PR looks good. Links have been added on this page.

Feel free to open more pulls in the future, only together can we encompass as much as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants