Added and Fixed some strings #164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You might have to make a new branch and re-do these changes based off of the current unstable if you can't fix the merge conflicts |
8 tasks
|
I made a new PR that resolves the merge conflicts, since I couldn't do it on your repo #199 |
|
If you could fact check the changes that'd be nice since resolving via cmd can cause issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What have you changed and why?
Information: Added missing Korean strings, fixed "<;/Key>>" to "<;/Key>" and improved some Koreans.
P.S: The semicolon was added intentionally so that this character would appear in this article. Of course, Stringtable doesn't have that.
Please specify which Issue this PR Resolves (If Applicable).
"This PR closes #XXXX!"
Please verify the following.
Is further testing or are further changes required?
How can the changes be tested?
Steps: Just change the language of the game to Korean and run it.
Notes: I didn't test as a dedicated server. After all, there is meaningless in testing the dedicated server because it runs only with the Original string, not the language of the server's country.