Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browse_website is broken on RPi #2219

Closed
1 task done
talvasconcelos opened this issue Apr 17, 2023 · 12 comments
Closed
1 task done

browse_website is broken on RPi #2219

talvasconcelos opened this issue Apr 17, 2023 · 12 comments
Assignees
Labels
bug Something isn't working function: browse needs investigation platform dependent When something works but not on all platforms Stale

Comments

@talvasconcelos
Copy link

Duplicates

  • I have searched the existing issues

Summary 💡

On latest, using selenium, on an arm device, browse_website doesn't work, as it doesn't get the correct (if any) drivers.

Also, using chromium, as there's no chrome on the RPI, needs some selenium love, I'm trying to add it locally but still testing.

Please guys, don't start assuming everyone is on a desktop, or on windows, or any assumptions!

Examples 🌈

No response

Motivation 🔦

No response

@2tYfX8sgnrx
Copy link

2tYfX8sgnrx commented Apr 17, 2023

I tried adding mozilla geckodriver in attempt to get Firefox working but it still defaults to chrome which is not installed on the M1 Macbook I'm running.

Changing the .env file settings to point towards Safari also isn't working at the moment, defaulting to chrome still.

Selenium does need love.

@k-boikov
Copy link
Contributor

Might be fixed with #1473

@Pwuts
Copy link
Member

Pwuts commented Apr 18, 2023

Please guys, don't start assuming everyone is on a desktop, or on windows, or any assumptions!

We learned that the hard way over the past week :')

@Pwuts Pwuts changed the title I run AutoGPT on the RPI. Selenium make browse_website a bust... browse_website with Selenium broken on RPi Apr 18, 2023
@Pwuts Pwuts added the platform dependent When something works but not on all platforms label Apr 18, 2023
@Pwuts Pwuts moved this to 📋 Backlog in AutoGPT development kanban Apr 18, 2023
@sadmuphin
Copy link
Contributor

Chromium is supported, and with #2066 you should be able to specify the chromium binary (I'm not sure if that will fix as I think you would still selenium drivers). However I do agree, non-selenium web-scraping should still be supported.

@Pwuts Pwuts added the bug Something isn't working label Apr 19, 2023
@Pwuts Pwuts changed the title browse_website with Selenium broken on RPi browse_website is broken on RPi Apr 19, 2023
@Pwuts
Copy link
Member

Pwuts commented Apr 19, 2023

@talvasconcelos can you post the output of the WebDriver manager? (like in #2600)

@Pwuts
Copy link
Member

Pwuts commented Apr 21, 2023

@talvasconcelos
Copy link
Author

@talvasconcelos can you post the output of the WebDriver manager? (like in #2600)

i don't have an output, webdriver just installs the wrong driver (i assume it's because of the settings in user-agent)

@Pwuts
Copy link
Member

Pwuts commented Apr 23, 2023

Which one does it install, and which one should it install?

@talvasconcelos
Copy link
Author

talvasconcelos commented Apr 28, 2023

Which one does it install, and which one should it install?

this is the error i get on the RPI: SYSTEM: Command browse_website returned: Error: [Errno 8] Exec format error: '~/.wdm/drivers/chromedriver/linux64/112.0.5615.49/chromedriver'

I believe the issue is in this line, that "hardcodes" a platform and a driver: https://github.com/Significant-Gravitas/Auto-GPT/blob/20ef130341981e7500039e31d87e566e432acdd7/autogpt/commands/web_selenium.py#L76-L78

Since there's no chrome in the RPI, only chromium, this fails not only because it's getting a driver for the wrong architecture, as it insists on chrome! I found this, if it helps making it work: https://ivanderevianko.com/2020/01/selenium-chromedriver-for-raspberrypi

@k-boikov
Copy link
Contributor

The user-agent is used only for the http request header, that could not be the issue.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

This issue has automatically been marked as stale because it has not had any activity in the last 50 days. You can unstale it by commenting or removing the label. Otherwise, this issue will be closed in 10 days.

@github-actions github-actions bot added the Stale label Sep 6, 2023
@github-actions
Copy link
Contributor

This issue was closed automatically because it has been stale for 10 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 17, 2023
@github-project-automation github-project-automation bot moved this from 🔖 Valuable & Actionable to ✅ Done in AutoGPT development kanban Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working function: browse needs investigation platform dependent When something works but not on all platforms Stale
Projects
Archived in project
Development

No branches or pull requests

5 participants