Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Initial proposal for the abstract base class for the
Configuration
subsystem. Part of re-arch #3717. Discussion thread on discord. Looking for feedbackChanges
set_defaults
abstract method.The expected use would be something like
A concrete implementation can choose a container (a dict) for example. Ideally the implementation defines something like a TypedDict for the return types of the accessors (or something static analysis-friendly).
Documentation
Open to suggestions on this...