Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove service overview API #6495

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

nityanandagohain
Copy link
Member

@nityanandagohain nityanandagohain commented Nov 20, 2024

Part of #5713


Important

Remove GetServiceOverview function, related API endpoint, and associated parsers and interface methods.

  • API Removal:
    • Removed GetServiceOverview function from reader.go.
    • Removed getServiceOverview handler from http_handler.go.
    • Removed /api/v1/service/overview route from http_handler.go.
  • Parser Removal:
    • Removed parseGetServiceOverviewRequest from parser.go.
  • Interface Update:
    • Removed GetServiceOverview from Reader interface in interface.go.

This description was created by Ellipsis for 746c059. It will automatically update as commits are pushed.

@nityanandagohain nityanandagohain marked this pull request as ready for review November 20, 2024 17:07
@github-actions github-actions bot added the bug Something isn't working label Nov 20, 2024
@nityanandagohain nityanandagohain changed the title fix: remove service overview function fix: remove service overview API Nov 20, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 746c059 in 24 seconds

More details
  • Looked at 448 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. pkg/query-service/interfaces/interface.go:19
  • Draft comment:
    The removal of the GetServiceOverview method from the Reader interface is consistent with the removal of its implementation. This keeps the interface clean and avoids declaring unused methods.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The removal of the GetServiceOverview method from the Reader interface in the interfaces/interface.go file is consistent with the removal of the implementation in the clickhouseReader/reader.go file. This ensures that the interface does not declare methods that are not implemented, maintaining consistency and avoiding potential runtime errors.
2. pkg/query-service/interfaces/interface.go:19
  • Draft comment:
    Remove GetServiceOverview from the Reader interface as it has been removed from the implementation.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_CJGWAF4T72g4KNoM


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@nityanandagohain nityanandagohain merged commit 5044861 into develop Nov 20, 2024
18 checks passed
@nityanandagohain nityanandagohain deleted the fix/remove-service-overview branch November 20, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants