-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve traces table ux by making the table scrollable #6423
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to bcb439e in 31 seconds
More details
- Looked at
27
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. frontend/src/pages/TracesExplorer/TracesExplorer.styles.scss:51
- Draft comment:
Ensure that the width adjustment for.trace-explorer
in light mode is consistent with the dark mode to avoid layout issues. Consider usingcalc(100% - 260px)
for consistency. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_PlOPAEUtOogskxQX
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
… true to max-content
@@ -49,7 +49,7 @@ | |||
} | |||
|
|||
.trace-explorer { | |||
width: 100%; | |||
width: calc(100% - 260px); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahmadshaheer : Why -260px?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
In case we have too many columns in the list view of traces explorer, the UI breaks, and the columns can't be resized properly. This PR fixes these issues by making the table horizontally scrollable.
Related Issues / PR's
close #6326
Screenshots
2024-11-12.09-56-20.mov
Affected Areas and Manually Tested Areas
Important
Makes the traces explorer table horizontally scrollable to handle cases with too many columns.
ListView/index.tsx
horizontally scrollable by settingscroll={{ x: 'max-content' }}
in theResizeTable
component..trace-explorer
width inTracesExplorer.styles.scss
tocalc(100% - 260px)
to accommodate the scrollable table.This description was created by for a50bd99. It will automatically update as commits are pushed.