Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve traces table ux by making the table scrollable #6423

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ahmadshaheer
Copy link
Collaborator

@ahmadshaheer ahmadshaheer commented Nov 12, 2024

Summary

In case we have too many columns in the list view of traces explorer, the UI breaks, and the columns can't be resized properly. This PR fixes these issues by making the table horizontally scrollable.

Related Issues / PR's

close #6326

Screenshots

2024-11-12.09-56-20.mov

Affected Areas and Manually Tested Areas

  • List view of traces explorer

Important

Makes the traces explorer table horizontally scrollable to handle cases with too many columns.

  • Behavior:
    • Makes the table in ListView/index.tsx horizontally scrollable by setting scroll={{ x: 'max-content' }} in the ResizeTable component.
    • Adjusts .trace-explorer width in TracesExplorer.styles.scss to calc(100% - 260px) to accommodate the scrollable table.
  • Affected Areas:
    • List view of traces explorer, specifically when there are too many columns.

This description was created by Ellipsis for a50bd99. It will automatically update as commits are pushed.

@github-actions github-actions bot added the bug Something isn't working label Nov 12, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to bcb439e in 31 seconds

More details
  • Looked at 27 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/src/pages/TracesExplorer/TracesExplorer.styles.scss:51
  • Draft comment:
    Ensure that the width adjustment for .trace-explorer in light mode is consistent with the dark mode to avoid layout issues. Consider using calc(100% - 260px) for consistency.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_PlOPAEUtOogskxQX


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

frontend/src/components/ResizeTable/ResizeTable.tsx Outdated Show resolved Hide resolved
@@ -49,7 +49,7 @@
}

.trace-explorer {
width: 100%;
width: calc(100% - 260px);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahmadshaheer : Why -260px?

Copy link
Collaborator Author

@ahmadshaheer ahmadshaheer Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YounixM, the traces filter has a width of 260px. I subtracted it from 100% to ensure that the traces explorer slide to the side when there are too many columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve traces list view ux when there are more columns
2 participants