-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add v2 metric writer to pipelines #6345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to aef3916 in 1 minute and 2 seconds
More details
- Looked at
144
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
5
drafted comments based on config settings.
1. deploy/docker-swarm/clickhouse-setup/otel-collector-config.yaml:149
- Draft comment:
Ensureclickhousemetricswritev2
is compatible with existing data flow and does not introduce performance issues or data inconsistencies. - Reason this comment was not posted:
Confidence changes required:50%
Theclickhousemetricswritev2
exporter is added to multiple pipelines, which is correct as per the PR intent. However, it's important to ensure that the new exporter is compatible with the existing data flow and does not introduce any performance bottlenecks or data inconsistencies. This should be tested thoroughly.
2. deploy/docker/clickhouse-setup/otel-collector-config.yaml:154
- Draft comment:
Ensureclickhousemetricswritev2
is compatible with existing data flow and does not introduce performance issues or data inconsistencies. - Reason this comment was not posted:
Confidence changes required:50%
Theclickhousemetricswritev2
exporter is added to multiple pipelines, which is correct as per the PR intent. However, it's important to ensure that the new exporter is compatible with the existing data flow and does not introduce any performance bottlenecks or data inconsistencies. This should be tested thoroughly.
3. deploy/docker-swarm/clickhouse-setup/otel-collector-config.yaml:116
- Draft comment:
No issues found with the changes in this PR according to the specified rules. - Reason this comment was not posted:
Confidence changes required:0%
The PR does not violate any of the specified rules. The changes are consistent with the existing structure and do not introduce any hardcoded colors, inline styles, or unrelated functions to the ClickHouseReader interface. The file structure is also appropriate for the context.
4. deploy/docker/clickhouse-setup/otel-collector-config.yaml:125
- Draft comment:
No issues found with the changes in this PR according to the specified rules. - Reason this comment was not posted:
Confidence changes required:0%
The PR does not violate any of the specified rules. The changes are consistent with the existing structure and do not introduce any hardcoded colors, inline styles, or unrelated functions to the ClickHouseReader interface. The file structure is also appropriate for the context.
5. deploy/docker/clickhouse-setup/otel-collector-config.yaml:128
-
Draft comment:
Duplicate configuration forclickhousemetricswritev2
exporter found indeploy/docker-swarm/clickhouse-setup/otel-collector-config.yaml
. Consider reusing the existing configuration. -
clickhousemetricswritev2 exporter configuration (otel-collector-config.yaml)
-
Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_3NK5XjW1qIrKqxLD
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
@prashant-shahi please approve |
Summary
Part of #5975
Important
Add
clickhousemetricswritev2
exporter to OpenTelemetry collector configurations and removesignozspanmetrics/cumulative
processor.clickhousemetricswritev2
tootel-collector-config.yaml
in bothdocker-swarm
anddocker
setups.signozspanmetrics/cumulative
processor fromotel-collector-config.yaml
in bothdocker-swarm
anddocker
setups.metrics
,metrics/hostmetrics
, andmetrics/prometheus
pipelines to includeclickhousemetricswritev2
exporter in bothdocker-swarm
anddocker
setups.This description was created by for aef3916. It will automatically update as commits are pushed.