Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add v2 metric writer to pipelines #6345

Merged
merged 4 commits into from
Nov 13, 2024
Merged

chore: add v2 metric writer to pipelines #6345

merged 4 commits into from
Nov 13, 2024

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Nov 2, 2024

Summary

Part of #5975


Important

Add clickhousemetricswritev2 exporter to OpenTelemetry collector configurations and remove signozspanmetrics/cumulative processor.

  • Exporters:
    • Add clickhousemetricswritev2 to otel-collector-config.yaml in both docker-swarm and docker setups.
  • Processors:
    • Remove signozspanmetrics/cumulative processor from otel-collector-config.yaml in both docker-swarm and docker setups.
  • Pipelines:
    • Update metrics, metrics/hostmetrics, and metrics/prometheus pipelines to include clickhousemetricswritev2 exporter in both docker-swarm and docker setups.

This description was created by Ellipsis for aef3916. It will automatically update as commits are pushed.

@github-actions github-actions bot added the chore label Nov 2, 2024
@srikanthccv srikanthccv marked this pull request as ready for review November 9, 2024 12:36
@srikanthccv srikanthccv requested a review from a team as a code owner November 9, 2024 12:36
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to aef3916 in 1 minute and 2 seconds

More details
  • Looked at 144 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 drafted comments based on config settings.
1. deploy/docker-swarm/clickhouse-setup/otel-collector-config.yaml:149
  • Draft comment:
    Ensure clickhousemetricswritev2 is compatible with existing data flow and does not introduce performance issues or data inconsistencies.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The clickhousemetricswritev2 exporter is added to multiple pipelines, which is correct as per the PR intent. However, it's important to ensure that the new exporter is compatible with the existing data flow and does not introduce any performance bottlenecks or data inconsistencies. This should be tested thoroughly.
2. deploy/docker/clickhouse-setup/otel-collector-config.yaml:154
  • Draft comment:
    Ensure clickhousemetricswritev2 is compatible with existing data flow and does not introduce performance issues or data inconsistencies.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The clickhousemetricswritev2 exporter is added to multiple pipelines, which is correct as per the PR intent. However, it's important to ensure that the new exporter is compatible with the existing data flow and does not introduce any performance bottlenecks or data inconsistencies. This should be tested thoroughly.
3. deploy/docker-swarm/clickhouse-setup/otel-collector-config.yaml:116
  • Draft comment:
    No issues found with the changes in this PR according to the specified rules.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR does not violate any of the specified rules. The changes are consistent with the existing structure and do not introduce any hardcoded colors, inline styles, or unrelated functions to the ClickHouseReader interface. The file structure is also appropriate for the context.
4. deploy/docker/clickhouse-setup/otel-collector-config.yaml:125
  • Draft comment:
    No issues found with the changes in this PR according to the specified rules.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR does not violate any of the specified rules. The changes are consistent with the existing structure and do not introduce any hardcoded colors, inline styles, or unrelated functions to the ClickHouseReader interface. The file structure is also appropriate for the context.
5. deploy/docker/clickhouse-setup/otel-collector-config.yaml:128
  • Draft comment:
    Duplicate configuration for clickhousemetricswritev2 exporter found in deploy/docker-swarm/clickhouse-setup/otel-collector-config.yaml. Consider reusing the existing configuration.

  • clickhousemetricswritev2 exporter configuration (otel-collector-config.yaml)

  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_3NK5XjW1qIrKqxLD


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@srikanthccv
Copy link
Member Author

@prashant-shahi please approve

@srikanthccv srikanthccv enabled auto-merge (squash) November 13, 2024 10:35
@srikanthccv srikanthccv merged commit 969ac50 into develop Nov 13, 2024
15 of 16 checks passed
@srikanthccv srikanthccv deleted the add-v2writer branch November 13, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants