Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update request payload for span metrics queries #6323

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Oct 30, 2024

Summary

Fix #6322


Important

Add timeAggregateOperators and spaceAggregateOperators to span metrics queries for improved aggregation handling.

  • Behavior:
    • Add timeAggregateOperators and spaceAggregateOperators to query functions in DBCallQueries.ts, ExternalQueries.ts, OverviewQueries.ts.
    • Update getQueryBuilderQueries and getQueryBuilderQuerieswithFormula in MetricsPageQueriesFactory.ts to handle new parameters.
  • Types:
    • Update BuilderQueriesProps and BuilderQuerieswithFormulaProps in types.ts to include new parameters.
  • Constants:
    • Use MetricAggregateOperator and TracesAggregatorOperator enums in constant.ts for latency aggregation.

This description was created by Ellipsis for 2e36fb8. It will automatically update as commits are pushed.

@github-actions github-actions bot added the bug Something isn't working label Oct 30, 2024
@srikanthccv srikanthccv marked this pull request as ready for review November 9, 2024 12:40
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 2e36fb8 in 57 seconds

More details
  • Looked at 191 lines of code in 6 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. frontend/src/container/MetricsApplication/MetricsPageQueries/OverviewQueries.ts:87
  • Draft comment:
    Ensure that MetricAggregateOperator.EMPTY is a valid operator and is supported by the backend to avoid potential errors or incorrect query results. This is also applicable in other places where MetricAggregateOperator.EMPTY is used.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. frontend/src/container/MetricsApplication/MetricsPageQueries/DBCallQueries.ts:58
  • Draft comment:
    Avoid using the component/index.tsx file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This is applicable in other files as well.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_yzHyDPQaehe2bGUg


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@srikanthccv srikanthccv enabled auto-merge (squash) November 12, 2024 16:55
@srikanthccv srikanthccv merged commit 85ac21f into develop Nov 12, 2024
16 of 17 checks passed
@srikanthccv srikanthccv deleted the issue-6322 branch November 12, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the request payload for Latency and apdex when USE_SPAN_METRICS is enabled
3 participants