Chore: bump signoz otel collector dependency to 0.111.5 #6302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 5265a4b in 27 seconds
More details
- Looked at
742lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. pkg/query-service/app/clickhouseReader/filter_suggestions.go:11
- Draft comment:
Update the import path forResourceHierarchyto usefingerprintinstead oflogsv2. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment is redundant because the change it suggests has already been implemented in the diff. The import path has been updated fromlogsv2tofingerprint, so there is no action required based on this comment.
I might be missing some context about why the comment was made, but based on the diff, the change has already been applied, making the comment unnecessary.
The diff clearly shows the change has been made, so the comment is not needed regardless of any additional context.
The comment should be deleted because the suggested change has already been implemented in the diff.
Workflow ID: wflow_KUjDHH4VLnLNRdh3
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
prashant-shahi
approved these changes
Oct 28, 2024
prashant-shahi
deleted the
chore/bump-signoz-otel-collector-dependency-to-0.111.5
branch
eKuG
pushed a commit
that referenced
this pull request
Oct 28, 2024
* chore: bump signoz-otel-collector dependency version to 0.111.5 * chore: logs filter suggestions: update import for ResourceHierarchy from signoz-otel-collector
eKuG
added a commit
that referenced
this pull request
Oct 28, 2024
…6260) * fix: fixed the step interval which was being perculated to list view * fix: fixed the step interval which was being perculated to list view * fix: fixed the step interval which was being perculated to list view * fix: fixed the step interval which was being perculated to list view * fix: fixed the step interval which was being perculated to list view * fix: fixed the step interval which was being perculated to list view * chore: bump signoz-otel-collector version (#6290) * Chore: bump signoz otel collector dependency to 0.111.5 (#6302) * chore: bump signoz-otel-collector dependency version to 0.111.5 * chore: logs filter suggestions: update import for ResourceHierarchy from signoz-otel-collector * fix: fixed the step interval which was being perculated to list view --------- Co-authored-by: Srikanth Chekuri <[email protected]> Co-authored-by: Raj Kamal Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
bump signoz otel collector dependency to 0.111.5
Related Issues / PR's
fixes https://github.com/SigNoz/engineering-pod/issues/1948
Important
Bump
signoz-otel-collectordependency tov0.111.5and update import path infilter_suggestions.go.signoz-otel-collectordependency fromv0.111.2tov0.111.5ingo.modandgo.sum.exporter/clickhouselogsexporter/logsv2toutils/fingerprintinfilter_suggestions.go.This description was created by
for 5265a4b. It will automatically update as commits are pushed.