-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: upgrade signoz otel collector dependency to v0.111.2 #6257
Chore: upgrade signoz otel collector dependency to v0.111.2 #6257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 16efdde in 39 seconds
More details
- Looked at
895
lines of code in10
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. pkg/query-service/collectorsimulator/collectorsimulator.go:141
- Draft comment:
Ensure the cleanup function is called in all error cases to prevent resource leaks. For example, in this error case, the cleanup function should be invoked before returning. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_3lU1xXIx0rSFl0U0
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to a6cfc42 in 30 seconds
More details
- Looked at
905
lines of code in10
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. pkg/query-service/collectorsimulator/inmemoryexporter/exporter_test.go:62
- Draft comment:
Ensure that the change fromexporter.CreateSettings
toexporter.Settings
is consistent with the updated API in the new version of the dependency. This change is correctly applied here and in other relevant files. - Reason this comment was not posted:
Confidence changes required:0%
The PR updates the usage ofexporter.CreateSettings
toexporter.Settings
andreceiver.CreateSettings
toreceiver.Settings
in multiple files. This change is consistent with the updated API in the new version of the dependency. The change is correctly applied in all relevant files, includingexporter_test.go
,factory.go
,factory_test.go
,receiver_test.go
, andcollectorsimulator.go
.
Workflow ID: wflow_Clij6yoJ8u6MpmzI
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
…dency-to-v0.111.2
…dency-to-v0.111.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
…dency-to-v0.111.2
Summary
Upgrades signoz-otel-collector dependency to v0.111.2 (used for collector simulation and logs pipeline previews) and makes relevant fixes/changes
Related Issues / PR's
#6253
SigNoz/signoz-otel-collector#418
Important
Upgrade
signoz-otel-collector
tov0.111.2
and update codebase for compatibility with new API changes.signoz-otel-collector
tov0.111.2
ingo.mod
andgo.sum
.go-oidc
,prometheus/common
,rs/cors
, and other dependencies to newer versions.GenerateCollectorConfigWithPipelines
incollector_config.go
to escape$
as$$$
.CollectorSimulator
incollectorsimulator.go
to use newservice.Settings
fields.exporter.CreateSettings
toexporter.Settings
ininmemoryexporter
andinmemoryreceiver
components.exporter_test.go
,factory_test.go
, andreceiver_test.go
to reflect API changes.This description was created by for a6cfc42. It will automatically update as commits are pushed.