Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: upgrade signoz otel collector dependency to v0.111.2 #6257

Merged

Conversation

raj-k-singh
Copy link
Collaborator

@raj-k-singh raj-k-singh commented Oct 24, 2024

Summary

Upgrades signoz-otel-collector dependency to v0.111.2 (used for collector simulation and logs pipeline previews) and makes relevant fixes/changes

Related Issues / PR's

#6253
SigNoz/signoz-otel-collector#418


Important

Upgrade signoz-otel-collector to v0.111.2 and update codebase for compatibility with new API changes.

  • Dependencies:
    • Upgrade signoz-otel-collector to v0.111.2 in go.mod and go.sum.
    • Update go-oidc, prometheus/common, rs/cors, and other dependencies to newer versions.
  • Code Changes:
    • Modify GenerateCollectorConfigWithPipelines in collector_config.go to escape $ as $$$.
    • Update CollectorSimulator in collectorsimulator.go to use new service.Settings fields.
    • Change exporter.CreateSettings to exporter.Settings in inmemoryexporter and inmemoryreceiver components.
  • Tests:
    • Update tests in exporter_test.go, factory_test.go, and receiver_test.go to reflect API changes.

This description was created by Ellipsis for a6cfc42. It will automatically update as commits are pushed.

@raj-k-singh raj-k-singh marked this pull request as draft October 24, 2024 09:07
@github-actions github-actions bot added the chore label Oct 24, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 16efdde in 39 seconds

More details
  • Looked at 895 lines of code in 10 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pkg/query-service/collectorsimulator/collectorsimulator.go:141
  • Draft comment:
    Ensure the cleanup function is called in all error cases to prevent resource leaks. For example, in this error case, the cleanup function should be invoked before returning.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_3lU1xXIx0rSFl0U0


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@raj-k-singh raj-k-singh marked this pull request as ready for review October 24, 2024 09:35
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to a6cfc42 in 30 seconds

More details
  • Looked at 905 lines of code in 10 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pkg/query-service/collectorsimulator/inmemoryexporter/exporter_test.go:62
  • Draft comment:
    Ensure that the change from exporter.CreateSettings to exporter.Settings is consistent with the updated API in the new version of the dependency. This change is correctly applied here and in other relevant files.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR updates the usage of exporter.CreateSettings to exporter.Settings and receiver.CreateSettings to receiver.Settings in multiple files. This change is consistent with the updated API in the new version of the dependency. The change is correctly applied in all relevant files, including exporter_test.go, factory.go, factory_test.go, receiver_test.go, and collectorsimulator.go.

Workflow ID: wflow_Clij6yoJ8u6MpmzI


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@raj-k-singh raj-k-singh merged commit 5891fbc into develop Oct 28, 2024
12 of 13 checks passed
@raj-k-singh raj-k-singh deleted the chore/upgrade-signoz-otel-collector-dependency-to-v0.111.2 branch October 28, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants