fix: fixed incorrect label for orderBy clause when selected #6177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues / PR's
#5663
https://github.com/SigNoz/engineering-pod/issues/1689
Screenshots
Before:
Screen.Recording.2024-10-14.at.9.33.23.AM.mov
After:
Screen.Recording.2024-10-14.at.9.30.09.AM.mov
Affected Areas and Manually Tested Areas
Tested:
Important
Fixes incorrect label for
orderBy
clause in query builder by consideringentityVersion
intransformToOrderByStringValues
.orderBy
clause intransformToOrderByStringValues
inutils.ts
by consideringentityVersion
.selectedValue
computation inuseOrderByFilter.ts
to use the correctedtransformToOrderByStringValues
function.transformToOrderByStringValues
now takesentityVersion
as an optional parameter to determine label format.columnName
isSIGNOZ_VALUE
andentityVersion
is 'v4'.This description was created by for 3b0fcfb. It will automatically update as commits are pushed.