Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove trailing slash from http payload example #6176

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

Rohukas
Copy link
Contributor

@Rohukas Rohukas commented Oct 14, 2024

Summary

Removed trailing slash from the httpJsonPayload curl command. This change prevents the request from returning a 404 error by correctly using the endpoint without a trailing slash.

Related Issues / PR's

NA

Screenshots

NA

NA

NA


Important

Remove trailing slash from URL in httpJsonPayload.md cURL command to prevent 404 errors.

  • Behavior:
    • Removed trailing slash from URL in httpJsonPayload.md cURL command example to prevent 404 errors.

This description was created by Ellipsis for 8657def. It will automatically update as commits are pushed.

@Rohukas Rohukas requested a review from YounixM as a code owner October 14, 2024 00:14
Copy link

welcome bot commented Oct 14, 2024

Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗

@CLAassistant
Copy link

CLAassistant commented Oct 14, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 8657def in 6 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. frontend/src/container/OnboardingContainer/Modules/LogsManagement/Http/md-docs/httpJsonPayload.md:63
  • Draft comment:
    The removal of the trailing slash from the URL is correct and prevents potential 404 errors when making the request.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR correctly removes the trailing slash from the URL in the cURL command, which aligns with the intent to prevent 404 errors. This change is appropriate and does not introduce any issues.
2. frontend/src/container/OnboardingContainer/Modules/LogsManagement/Http/md-docs/httpJsonPayload.md:63
  • Draft comment:
    The change to remove the trailing slash in the URL is correct and does not violate any specified rules.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR changes are correct and do not violate any of the specified rules. The change is a simple removal of a trailing slash in a URL, which is appropriate for the context.

Workflow ID: wflow_7coZltQaz36E6sCS


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@YounixM YounixM merged commit 7ed6896 into SigNoz:develop Oct 14, 2024
11 of 14 checks passed
Copy link

welcome bot commented Oct 14, 2024

Congrats on merging your first pull request!
minion-party
We here at SigNoz are proud of you! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants