fix: add settings to drop table (#459)

Add support for settings in drop table


FOR SigNoz/signoz#5713

cmd/signozschemamigrator/schema_migrator/table_operations.go

@@ -94,6 +94,7 @@ type DropTableOperation struct {
 	cluster  string
 	Database string
 	Table    string
+	Settings TableSettings
 }
 
 func (d DropTableOperation) OnCluster(cluster string) Operation {
@@ -132,6 +133,10 @@ func (d DropTableOperation) ToSQL() string {
 		sql.WriteString(" ON CLUSTER ")
 		sql.WriteString(d.cluster)
 	}
+	if len(d.Settings) > 0 {
+		sql.WriteString(" SETTINGS ")
+		sql.WriteString(d.Settings.ToSQL())
+	}
 	return sql.String()
 }
 

cmd/signozschemamigrator/schema_migrator/table_operations_test.go

@@ -198,6 +198,38 @@ func TestCreateTable(t *testing.T) {
 	}
 }
 
+func TestDropTable(t *testing.T) {
+	testCases := []struct {
+		name string
+		op   Operation
+		want string
+	}{
+		{
+			name: "drop-table",
+			op: DropTableOperation{
+				Database: "db",
+				Table:    "table",
+			},
+			want: "DROP TABLE IF EXISTS db.table",
+		},
+		{
+			name: "drop-table-with-settings",
+			op: DropTableOperation{
+				Database: "db",
+				Table:    "table",
+				Settings: TableSettings{{Name: "max_table_size_to_drop", Value: "0"}},
+			},
+			want: "DROP TABLE IF EXISTS db.table SETTINGS max_table_size_to_drop = 0",
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			require.Equal(t, tc.want, tc.op.ToSQL())
+		})
+	}
+}
+
 func TestCreateMaterializedView(t *testing.T) {
 	testCases := []struct {
 		name string