-
Notifications
You must be signed in to change notification settings - Fork 46
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: use the correct algorithm to request item information (#936)
* fix: use callbacks to fetch item information from the server It turns out that you do need to use callbacks to fetch all item information from the server. Modify the update code to listen for ITEM_DATA_LOAD_RESULT events to execute a callback to properly update an equipped item. Change the way that `Ovale_EquipmentChanged` is fired by always including the slot name that has been changed. The event now fires whenever ITEM_DATA_LOAD_RESULT returns success and the slot that had a pending data load has been changed. This avoids needing the 3-second delay kludge to wait for server data. * fix: consistently use SlotName instead of InventorySlotName in API Make all Ovale modules consistently use `ammoslot`, etc., instead of `AMMOSLOT`, etc., to refer to the names of the equipment slots. Make the conversion between the `SlotName` and `InventorySlotName` types internal to the `Equipment` module.
- Loading branch information
1 parent
565f696
commit b2a5315
Showing
4 changed files
with
244 additions
and
212 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.