This repository has been archived by the owner on Jul 7, 2024. It is now read-only.
Add the context menu after the welcome window #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koalalorenzo
suggested changes
Aug 21, 2018
app/index.js
Outdated
| * This adds the option "Add to IPFS via Orion" to the context menu of the OS, for files | ||
| * and directories. Currently only on windows. | ||
| */ | ||
| function enableContextMenu () { |
There was a problem hiding this comment.
Should we move this function into app/lib?
|
But then there would be absolutely no way to remove it, do we want that? |
|
We will add a new task to add a way to remove it. I feel we need to make a new section in the Settings :D |
koalalorenzo
suggested changes
Aug 21, 2018
app/index.js
Outdated
| @@ -111,6 +113,7 @@ function startWelcome () { | |||
| app.mainWindow = welcomeWindow | |||
| welcomeWindow.on('closed', () => { | |||
| if (Settings.get('welcomeVersion') === 1) { | |||
| enableContextMenu() | |||
There was a problem hiding this comment.
Can we add a small comment here? What is this doing here? :)
| @@ -5,7 +5,7 @@ import { trackEvent } from '../../../stats' | |||
|
|
|||
| import { Pane, Button, CheckBox } from 'react-photonkit' | |||
| import Input from '../../../components/Input' | |||
| import * as WinShell from '../../../util/win-shell' | |||
| import * as WinShell from '../../../lib/os-context-menu/win-shell' | |||
koalalorenzo
approved these changes
Aug 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Insert here the changes.