This repository has been archived by the owner on Jul 7, 2024. It is now read-only.
Upgrade to electron 2.0 + dependencies #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Secondary/Right click on elements seems not to work anymore. |
koalalorenzo
changed the title
|
The popup menu API changed: electron/electron#12915 |
|
This upgrade also changes the way Sentry is loaded: preload now changes compared to normal javascript files (outside window) |
koalalorenzo
changed the title
|
Ready for review: please test it a lot 😅 |
|
I've tested all the windows, it looks good! 👍 |
kernelwhisperer
approved these changes
Jun 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
package.json)app/lib/reportand divides the code forpreloadandnodesetuppopup()missing object due to electron 2.0.2