Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Updates #45

Closed
wants to merge 12 commits into from
Closed

Updates #45

wants to merge 12 commits into from

Conversation

dobladov
Copy link
Collaborator

@dobladov dobladov commented May 11, 2023

The action needs to be updated in order to keep workig: https://github.blog/changelog/2023-05-04-github-actions-all-actions-will-run-on-node16-instead-of-node12/

  • Use @vercel/ncc instead of deprecated @zeit/ncc
  • Upgrade to node 16
  • Upgraded typescript and types
  • Use createCommitStatus instead of deprecated createCommit
  • Use actions/checkout@v3

Fixes: #37

@rmichalak
Copy link

I gave it a try and I got this error:

Specified argument was out of the range of valid values. (Parameter ''using: node20' is not supported, use 'docker', 'node12' or 'node16' instead.')

You may want to downgrade to node16

@dobladov
Copy link
Collaborator Author

I was unsure if node20 was supported, I will downgrade to node16
actions/runner#2619

@MikeMcC399
Copy link

Currently only node16 is supported. See https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runsusing-for-javascript-actions

@ragmondo
Copy link

ragmondo commented Jun 7, 2023

@dobladov Can you publish your action please ? It looks as if this repo is not being actively maintained.

@dobladov
Copy link
Collaborator Author

dobladov commented Jun 7, 2023

@ragmondo I would still prefer if @Sibz continues being the maintainer, I'm not as knowledgable about the action internals, I only did some maintenance work for this PR.

I published my version on the marketplace, in case this repository stays unmaintained.
https://github.com/marketplace/actions/action-status

You can use the action with dobladov/[email protected], usage should be the same.

I will do some testing tomorrow to see if it works properly.

@Sibz
Copy link
Owner

Sibz commented Jun 25, 2023

@dobladov Can you publish your action please ? It looks as if this repo is not being actively maintained.

Sorry been away and isolated from the internet. I have some catching up to do.

@Sibz
Copy link
Owner

Sibz commented Jun 25, 2023

@dobladov I've added you as a collaborator as I do need help, I'm a bit overwhelmed at the moment.

@dobladov
Copy link
Collaborator Author

@guibranco thanks for approving, I still need someone to approve the check before merging.

@dobladov dobladov self-assigned this Jun 29, 2023
@dobladov
Copy link
Collaborator Author

Still can't merge.

Screenshot 2023-06-30 at 10 54 28

@dobladov
Copy link
Collaborator Author

dobladov commented Feb 13, 2024

In case it helps others, here is an alternative solution to create statuses, currently using node 16 and soon using node 20.

More info about the request: https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#create-a-commit-status

  - name: Create status
    uses: octokit/[email protected]
    with:
      route: POST /repos/{owner}/{repo}/statuses/{sha}
      owner: ${{ github.repository_owner }}
      repo: '${{ github.event.repository.name }}'
      sha: ${{ github.sha }}
      state: error, failure, pending, success
      target_url: ${{ env.JOB_URL }}
      context: ${{ env.STATUS_DESCRIPTION }}
    env:
      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

@guibranco
Copy link

@dobladov I am currently using an updated V2 version (a fork of this). If anyone is interested in trying it out, please use this URL: https://github.com/guibranco/github-status-action-v2.

I am curious to know whether the owner of this repository will return to approve or merge these PRs, or if they have abandoned all projects in their account. Their last activity on GitHub was in August 2023, and the last commit to this repository was over three years ago.

@dobladov dobladov closed this Mar 19, 2024
@dobladov dobladov deleted the updates branch March 19, 2024 09:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use Node.js 16
7 participants