Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Shelly 1, 2.5, and Plus 2PM #49

Merged
merged 3 commits into from
Jan 5, 2023
Merged

Conversation

peedub
Copy link
Contributor

@peedub peedub commented Jan 3, 2023

Added blueprints for Shelly 1, 2.5, and Plus 2PM. Generic images of switches have been used.

Blueprint Checklist

  • You viewed the README and conformed to the naming conventions
  • You ordered the actions as stated in the README action order
  • All filenames are lowercase and uses '-' for spaces and not '_' while using {service-name}-{switch-name-or-type}.yaml format
  • Images are png
  • Image backgrounds are transparent and is cropped to the device boundries
  • Images has a maximum width of 800px and maximum height of 500px
  • There are no missing buttons or actions
  • You have tested your blueprints and made sure each button and action works

@Sian-Lee-SA
Copy link
Owner

You've tested this and it all works?

@Sian-Lee-SA
Copy link
Owner

From what I can see, you have a yaml condition problem. when you do a press or hold it will fire both because you didn't define the conditions as an array, instead the below key and value will override the ones above.. Further more if the button being pushed and theres a value to check against for the button, then it should go in the button condition and not action

@peedub
Copy link
Contributor Author

peedub commented Jan 5, 2023

Thanks. Have made those corrections to the shelly 2.5 and shelly plus 2pm files. You're right, when I pushed the button, the lights would turn on then off. I had only tested it properly with the shelly 1 code.

@Sian-Lee-SA
Copy link
Owner

That looks better :) thanks for bringing in the first Shelly products!

@Sian-Lee-SA Sian-Lee-SA changed the title Add Shelly 1, 2.5, and Plus 2PM Addded Shelly 1, 2.5, and Plus 2PM Jan 5, 2023
@Sian-Lee-SA Sian-Lee-SA changed the title Addded Shelly 1, 2.5, and Plus 2PM Added Shelly 1, 2.5, and Plus 2PM Jan 5, 2023
@Sian-Lee-SA Sian-Lee-SA merged commit cd84921 into Sian-Lee-SA:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants