Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Zigbee2MQTT TuYa 1 and 2 gang remotes #44

Merged
merged 5 commits into from
Jan 4, 2023

Conversation

Mr-Groch
Copy link
Contributor

@Mr-Groch Mr-Groch commented Jan 3, 2023

Blueprint Checklist

  • You viewed the README and conformed to the naming conventions
  • You ordered the actions as stated in the README action order
  • All filenames are lowercase and uses '-' for spaces and not '_' while using {service-name}-{switch-name-or-type}.yaml format
  • Images are png
  • Image backgrounds are transparent and is cropped to the device boundries
  • Images has a maximum width of 800px and maximum height of 500px
  • There are no missing buttons or actions
  • You have tested your blueprints and made sure each button and action works

@Mr-Groch
Copy link
Contributor Author

Mr-Groch commented Jan 3, 2023

This is PR without switch modules - just normal remotes with standard Z2M action topic

@Sian-Lee-SA
Copy link
Owner

This has duplicates from your second PR. I will close this

@Sian-Lee-SA Sian-Lee-SA closed this Jan 3, 2023
@Mr-Groch
Copy link
Contributor Author

Mr-Groch commented Jan 3, 2023

Its not duplicate - I've created this PR for only those remotes that works similar to all other blueprints, so it can be quickly added - I think that switch modules will need some other work...

@Sian-Lee-SA
Copy link
Owner

Sian-Lee-SA commented Jan 3, 2023

The same files are in your other PR, you shouldn't create multiple PR's with the same files/blueprints

@Mr-Groch
Copy link
Contributor Author

Mr-Groch commented Jan 4, 2023

Can we reopen this? Those remotes are working fine. Switch modules are on seperate branch but created from this base, so that's why there and here are duplicates. If this will be merged, those duplicates will disapear on switch module branch becouse it is the same commit

@Sian-Lee-SA
Copy link
Owner

I will Merge it just to knock it out of the way but I prefer one PR for anything coming from an author or it starts getting messy. For example the conversation on the other PR is relating to commits in this PR and so on. Secondly, I will crop this for you but I do hope you take the time in the future to find a decent photo editing software and crop before making a PR. Thanks

@Sian-Lee-SA Sian-Lee-SA reopened this Jan 4, 2023
@Sian-Lee-SA Sian-Lee-SA changed the title Added TuYa 1 and 2 gang remotes for Z2M Added Zigbee2MQTT TuYa 1 and 2 gang remotes Jan 4, 2023
@Sian-Lee-SA Sian-Lee-SA merged commit 5fcd3a6 into Sian-Lee-SA:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants