Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use async_register_static_paths instead of register_static_path #247

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

Hypfer
Copy link
Contributor

@Hypfer Hypfer commented Aug 18, 2024

I saw that you were unhappy about having to deal with the breaking changes in HA so I figured that I could fix this one as well.
This fixes #242

It also unfortunately bumps the minimum required version of home assistant to 2024.7, as async_register_static_paths has been introduced with that version: home-assistant/core@faa55de

@Hypfer Hypfer force-pushed the async_register_static_paths branch from 384180a to 0d0ff69 Compare August 18, 2024 12:59
@Sian-Lee-SA
Copy link
Owner

Much appreciated, as it was noted by an issue from another user, it stated this integration had til 2025.7 to update to the new method, so wasn't high on my priority list. My frustrations stem from constant changes that could and should've happen in one update or a long time ago by the HA devs. But it seems every second or so update interval, there's a new deprecated name change or IO call. One update it would say that such and such IO is now a blocking call then the a few updates later another IO blocking call, then a deprecated function and so on.

I would've preferred if they sat down at one point then just communicated on what methods/functions will be called and used then do it in one update, That way it's not having us to constantly come back and conform.

My primary concern is a more stabalised and updated UI which is going to take a bit of time. The other issue I face is personal life and the renovations I'm currently doing and the single parenting etc. which hinders time I can spend on trying to keep this updated to reflect Home Asssistant changes.

I know this is a bit of a rant, but the appreciation of having someone PR these things when there's a 100 and 1 things to do outside of coding is real.

As I also mentioned previously, I generally avoid updating these days because I've become too comfortable with things just working while also relying on local devices (zigbee etc) and not being subjected to ecosystems that expose and tend to break things aswell. I just don't won't to let people down who rely on these integrations either.

@Sian-Lee-SA Sian-Lee-SA merged commit f54a723 into Sian-Lee-SA:master Aug 18, 2024
@Hypfer
Copy link
Contributor Author

Hypfer commented Aug 18, 2024

I just don't won't to let people down who rely on these integrations either.

Hey, please don't let yourself get crushed by the unreasonable expectations that have been pushed onto FOSS since the era of GitHub. You're not paid to care so don't.

As you mentioned, you have a ton of other stuff to do that actually matters. This does not.
You're not obligated to fix the minor luxury issues random people on the internet might have.

In fact, you already gave them all a huge gift with this software and even more so with this software being licensed under the GPL.
If people have a problem with it, they can trivially either fix it themselves or pay someone to do so.

And don't feel bad for venting when it is as reasonable as what you wrote here.
You're first and foremost a Human with human needs. No one is paying you to hide that so don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'switch_manager' calls hass.http.register_static_path which is deprecated
2 participants