Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Moes Smart Knob #145

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Added Moes Smart Knob #145

merged 2 commits into from
Jun 28, 2023

Conversation

bleughb
Copy link
Contributor

@bleughb bleughb commented Jun 25, 2023

Thankyou for your patience, Still a relative noob to Github

Blueprint Checklist

  • You viewed the README and conformed to the naming conventions
  • You ordered the actions as stated in the README action order
  • All filenames are lowercase and uses '-' for spaces and not '_' while using {service-name}-{switch-name-or-type}.yaml format
  • Images are png
  • Image backgrounds are transparent and is cropped to the device boundries
  • Images has a maximum width of 800px and maximum height of 500px
  • There are no missing buttons or actions
  • Your integration/service is running on the latest version
  • You have tested your blueprints and made sure each button and action works

Zigbee2MQTT

  • (older devices) You have ensured legacy is off/false for the device in the Z2M devices Settings (specific) page and that your actions matches those with legacy off?

bleughb added 2 commits June 26, 2023 07:21
Adding PNG file for the smart knob and also changed 'click' to 'press'
Added Moes Smart Knob - AKA ERS-10TZBVK-AA
@Sian-Lee-SA
Copy link
Owner

This PR has no changes to merge. Your previous closed PR can be updated which I can just reopen and merge. Will close this in favour of your previous PR.

@Sian-Lee-SA
Copy link
Owner

Also to be completely honest, I'm not an expert with Github myself but this PR has no changes to merge so I think there has been an issue with how or what you are wanting to push.

@Sian-Lee-SA
Copy link
Owner

After a quick investigation, it seems someone "hijacked" your PR then made their own with the same changes you made. This is why there's no changes showing for your PR because someone else did it... Sorry

@nwithan8
Copy link
Contributor

nwithan8 commented Jun 28, 2023

Sorry about that mate, my bad. Let the record show, all credit goes to @bleughb, I just fixed one spelling error on what I thought was an abandoned PR.

@Sian-Lee-SA
Copy link
Owner

Just to be clear, the devices you make PR's for needs to be tested/owned and used previously by yourself. If so then I have no issue.

@Sian-Lee-SA
Copy link
Owner

I will merge this even though it has no changes. This then puts you under the contributers list.

@Sian-Lee-SA Sian-Lee-SA reopened this Jun 28, 2023
@Sian-Lee-SA Sian-Lee-SA merged commit 5786915 into Sian-Lee-SA:master Jun 28, 2023
@Sian-Lee-SA Sian-Lee-SA changed the title Trying again - Adding Moes Smart Knob Added Moes Smart Knob Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants