Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ZHA 1 & 2 gang version of Aqara D1 switch #121

Merged
merged 3 commits into from
May 23, 2023

Conversation

Julien-Decoen
Copy link
Contributor

Blueprint Checklist

  • You viewed the README and conformed to the naming conventions
  • You ordered the actions as stated in the README action order
  • All filenames are lowercase and uses '-' for spaces and not '_' while using {service-name}-{switch-name-or-type}.yaml format
  • Images are png
  • Image backgrounds are transparent and is cropped to the device boundries
  • Images has a maximum width of 800px and maximum height of 500px
  • There are no missing buttons or actions
  • Your integration/service is running on the latest version
  • You have tested your blueprints and made sure each button and action works

Zigbee2MQTT

  • (older devices) You have ensured legacy is off/false for the device in the Z2M devices Settings (specific) page and that your actions matches those with legacy off?

@Lakitna
Copy link
Contributor

Lakitna commented May 6, 2023

Aqara has different model switches, it's probably a good idea to specify this in your blueprints. For example, I just opened a PR for different Aqara switches: #122

@Sian-Lee-SA
Copy link
Owner

Sian-Lee-SA commented May 11, 2023

This will have to be consulted with the other author(s) for those blueprints as I don't own, use or research these devices. Down the line there maybe an added tag field for blueprints which might try to eliminate the different vendors and similar switches etc but for filenames it's not that important as that is transparent to the end users. Title changes are easier enough to handle for such a case for now if it differentiates same vendor switches but again, this will have to be done via authors familiar with the products.

EDIT: Sorry just realised the PR OP is a different author to your comment derp but feel free to change the titles or whatever guys

@Sian-Lee-SA Sian-Lee-SA changed the title Aqara 1 & 2 gang remote ZHA Added ZHA Aqara 1 & 2 gang remote May 11, 2023
@Sian-Lee-SA
Copy link
Owner

A good source for reference would be https://www.zigbee2mqtt.io/supported-devices/ and find you device then use the model and description to help name your blueprints

@Julien-Decoen Julien-Decoen changed the title Added ZHA Aqara 1 & 2 gang remote Added ZHA 1 & 2 gang version of Aqara D1 switch May 11, 2023
@Julien-Decoen
Copy link
Contributor Author

Looks better, thanks :)

@Sian-Lee-SA
Copy link
Owner

What is default_sequence? this isn't a valid key

@Sian-Lee-SA
Copy link
Owner

Will close this until the invalid keys are removed

@Julien-Decoen
Copy link
Contributor Author

Oupsy. I made a little piece of code to give a default sequence from blueprint on my fork. But I forgot to delete it for the PR. I made changes.

@Julien-Decoen
Copy link
Contributor Author

Should I re-open it ? Or make another one ?

@Sian-Lee-SA Sian-Lee-SA reopened this May 23, 2023
@Sian-Lee-SA
Copy link
Owner

Sian-Lee-SA commented May 23, 2023

Just reopened for you, just update this PR with the changes then I can merge :)

Sorry just realised you already did update... Cheers!

@Sian-Lee-SA Sian-Lee-SA merged commit fc74653 into Sian-Lee-SA:master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants