-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ZHA 1 & 2 gang version of Aqara D1 switch #121
Added ZHA 1 & 2 gang version of Aqara D1 switch #121
Conversation
Aqara has different model switches, it's probably a good idea to specify this in your blueprints. For example, I just opened a PR for different Aqara switches: #122 |
This will have to be consulted with the other author(s) for those blueprints as I don't own, use or research these devices. Down the line there maybe an added tag field for blueprints which might try to eliminate the different vendors and similar switches etc but for filenames it's not that important as that is transparent to the end users. Title changes are easier enough to handle for such a case for now if it differentiates same vendor switches but again, this will have to be done via authors familiar with the products. EDIT: Sorry just realised the PR OP is a different author to your comment derp but feel free to change the titles or whatever guys |
A good source for reference would be https://www.zigbee2mqtt.io/supported-devices/ and find you device then use the model and description to help name your blueprints |
Looks better, thanks :) |
What is default_sequence? this isn't a valid key |
Will close this until the invalid keys are removed |
Oupsy. I made a little piece of code to give a default sequence from blueprint on my fork. But I forgot to delete it for the PR. I made changes. |
Should I re-open it ? Or make another one ? |
Just reopened for you, just update this PR with the changes then I can merge :) Sorry just realised you already did update... Cheers! |
Blueprint Checklist
Zigbee2MQTT