This repository has been archived by the owner on May 30, 2024. It is now read-only.
Use simple object for debugConfiguration.targetFolder #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `debugConfiguration` can be serialized/deserialized, `debugConfiguration.targetFolder.uri` may be converted into a plain JS object and loses the `fsPath` property and causes `cwd` to be undefined when working with a remote workspace. This commit fixes the issue by storing the `fsPath` property directly in `debugConfiguration.targetFolder`. Co-authored-by: Vinicius Stock <[email protected]>
vinistock
approved these changes
Jan 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Because
debugConfigurationcan be serialized/deserialized,debugConfiguration.targetFolder.urimay be converted into a plain JS object and loses thefsPathproperty and causescwdto be undefined when working with a remote workspace.Implementation
This commit fixes the issue by storing the
fsPathproperty directly indebugConfiguration.targetFolder.Automated Tests
Manual Tests
It's been manually tested on Spin.