This repository has been archived by the owner on May 30, 2024. It is now read-only.
Build test items in hierarchy if it's supported #914
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, tests in Test Explorer are assumed to only have 2 levels, which is incorrect, especially with RSpec tests.
With a 2 level nesting test file:
The current implementation doesn't display the nesting nor group tests correctly:
But with Shopify/ruby-lsp#1214 and this PR, we can deliever the correct result:
Closes Shopify/ruby-lsp#1744
Implementation
group_id
data attribute, we can build items hierarchy with them.Automated Tests
Manual Tests