This repository has been archived by the owner on May 30, 2024. It is now read-only.
Remove newlines from Ruby activation script #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
reviewed
Nov 20, 2023
andyw8
approved these changes
Nov 20, 2023
vinistock
force-pushed
the
vs/remove_newlines_from_ruby_activation_script
branch
from
bcf8903 to
dbdafcf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes Shopify/ruby-lsp#1708, closes Shopify/ruby-lsp#1175
Our Ruby activation script was too long, so we broke it into multiple lines. Based on the information shared in the issue, Windows does not seem to accept line breaks in terminal input and that ends up causing a syntax error.
Implementation
Instead of using a multiline string interpolation, I just changed to write the script in parts inside an array, which we join at the end.