This repository has been archived by the owner on May 30, 2024. It is now read-only.
Fix in/when dedent with language configuration #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary fix. We will submit a PR to fix this upstream in vscode itself, so that we don't need to bundle a language configuration file Co-authored-by: Soutaro Matsumoto <[email protected]>
vinistock
force-pushed
the
vs/fix_in_and_when_dedent
branch
from
89af3a7 to
77e88bf
Compare
|
Upstream PR microsoft/vscode#198349. |
andyw8
approved these changes
Nov 22, 2023
|
No reviews on the upstream PR yet, so I will merge this one so that we can improve the experience for now. Once the upstream PR is merged, we can revert this one and just rely on VS Code to do the right thing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes part of Shopify/ruby-lsp#1734
The issue with the indentation is the Ruby language configuration defined inside VS Code itself. We can expose a configuration to fix it temporarily, but we will upstream this to VS Code itself so that we don't have to bundle one.
Implementation
Instead of decreasing the indentation on
in|when, we only decrease on(in|when)\swhich waits for a single space to do it. That way, things likeincludewill never match and not reduce the indendation.