This repository has been archived by the owner on May 30, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I think there are a few opportunities to improve the code quality in our extension, make it easier to test and better prepare to support Shopify/ruby-lsp#1510.
This PR makes some refactors on
Ruby
and our output channel.Implementation
I recommend reviewing by commit.
For
Ruby
, there are basically three changes:RUBY_VERSION
and YJIT information. The only version manager where this is not possible isshadowenv
, which has a different activation mechanism. Forshadowenv
, we continue doing the sameFor the output channel, the changes are:
Started putting common functionality in a
common.ts
file. I will follow up with some more refactors that will likely move more stuff in there and simplify the existing classes.Automated Tests
Fixed tests where necessary.