This repository has been archived by the owner on May 30, 2024. It is now read-only.
Add Dependencies editor view
#1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Vinicius Stock <[email protected]>
Co-authored-by: Vinicius Stock <[email protected]>
Co-authored-by: Vinicius Stock <[email protected]>
This was referenced Feb 1, 2024
Closed
paracycle
commented
Feb 1, 2024
paracycle
force-pushed
the
uk-vs-bundler-view
branch
from
77ab8b5 to
8345c54
Compare
Co-authored-by: Vinicius Stock <[email protected]>
Co-authored-by: Vinicius Stock <[email protected]>
paracycle
force-pushed
the
uk-vs-bundler-view
branch
from
98891ab to
0064dad
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds a DEPENDENCIES view to the Editor sidebar, which shows the gem dependencies (including transitive ones) of a Ruby project and allows users to browse the contents of those dependencies without leaving their current editor.
Implementation
Most of the implementation is centred around the
dependenciesTree.tsfile which declares aTreeDataProviderclass with nestedTreeItemtypes under it. TheDependenciesTreeclass watches for changes in workspace, and when a new workspace is loaded, it makes therubyLsp/workspace/dependenciesLSP request to the server. Using the response, builds the appropriate dependency tree.Automated Tests
No tests yet.
Manual Tests
Open the current branch against Ruby LSP that includes changes in Shopify/ruby-lsp#1346 and you should be able to see a
DEPENDENCIESview in the Editor sidebar.