Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

Add code lens for running migrations #1015

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add code lens for running migrations #1015

wants to merge 1 commit into from

Conversation

gmcgibbon
Copy link
Member

Motivation

Adds code lens to run migrations to specific versions in the terminal. This is convenient because it allows developers to quickly rollback or fast-forward to specific schema versions with a click.

Part of Shopify/ruby-lsp-rails#239

Implementation

Followed the example of the test running controller and test command registration.

Automated Tests

I don't see any tests for the test command, do they exist? Happy to add tests if I have an example to follow.

Manual Tests

Build the extension, install the extension on a Rails app with Ruby LSP + Rails extension setup using Shopify/ruby-lsp-rails#239. Then, navigate to a migration to observe the added code lens.

@gmcgibbon gmcgibbon requested a review from a team as a code owner February 1, 2024 03:19
@gmcgibbon gmcgibbon requested review from st0012 and vinistock February 1, 2024 03:19
@gmcgibbon gmcgibbon force-pushed the run_migration branch 2 times, most recently from 1072615 to dd67c96 Compare February 3, 2024 04:11
Adds code lens to run migrations to specific versions in the terminal.
This is convenient because it allows developers to quickly rollback or
fast-forward to specific schema versions with a click.
Copy link
Contributor

github-actions bot commented Apr 3, 2024

This pull request is being marked as stale because there was no activity in the last 2 months

@github-actions github-actions bot added the Stale label Apr 3, 2024
@andyw8
Copy link
Contributor

andyw8 commented Apr 3, 2024

(we'll need to move this over to the monorepo)

@github-actions github-actions bot removed the Stale label Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants