This repository has been archived by the owner on May 30, 2024. It is now read-only.
Do not redirect to OUTPUT channel when debugger close on error
#1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
approved these changes
Jan 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes: Shopify/ruby-lsp#1687
OUTPUTchannel while debugger close on error due to file code. This redirection do not make sense as user want to see the error.DEBUG CONSOLEwas cleaned.Implementation
Just remove the
LOG_CHANNEL.show();part while debug session close on error.Automated Tests
Not added, feel free to ask if this is required.
Manual Tests
720-Screen.Recording.2024-01-30.at.16.12.43.mov