This repository has been archived by the owner on May 30, 2024. It is now read-only.
Convert test output newlines to \r\n #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test output is sent to vscode's terminal which uses \r\n to terminate lines. Convert any line just ending with \n to \r\n so that test output is not scrambled.
vinistock
approved these changes
Jan 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As is documented in the testing api documentation VSCode expects test output to have
\r\nnewlines, which is not the default value for many tools and it is up to the extension to convert them.Implementation
N/A
Automated Tests
Not implemented,
TestControllercurrently lacks unit tests.Manual Tests
Run a ruby unit test with multiline output, compare output with a run executed in the terminal.