Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ARMv6 & ARMv7 builds (for Raspberry Pi) #339

Merged
merged 3 commits into from
Nov 7, 2021

Conversation

mitchellrj
Copy link
Contributor

ARM64 builds are only supported on Raspberry Pi 4 if a non-standard OS image is installed. Any earlier Raspberry Pis, or stock Raspi4s don't have any binaries built for them.

In order to name the output files correctly, there is a bit more customization of the existing goreleaser file than I'd like, but it works well.

@ghost ghost added the cla-needed label Nov 6, 2021
@miry
Copy link
Contributor

miry commented Nov 6, 2021

@mitchellrj Awesome. I would test it, please meen time sign CLA and then I will rerun check.

Also update please CHANGELOG.md.

@miry miry self-assigned this Nov 6, 2021
@miry miry added this to the 2.3.0 milestone Nov 6, 2021
@miry miry mentioned this pull request Nov 6, 2021
9 tasks
@miry miry self-requested a review November 6, 2021 12:30
@miry
Copy link
Contributor

miry commented Nov 6, 2021

The goreleaser on Github is a bit old. Can you update to version: v0.184.0 also to make pass the build phase?

@miry
Copy link
Contributor

miry commented Nov 6, 2021

Reproduced the problem with 0.176.0:

~/go/bin/goreleaser release --rm-dist --skip-publish --skip-validate
   • releasing...     
   • loading config file       file=.goreleaser.yml
   • loading environment variables
   • getting and validating git state
      • building...               commit=e313f84421c3feb61314379a5ff1701a8bc55096 latest tag=v2.2.0
      • pipe skipped              error=validation is disabled
   • parsing tag      
   • running before hooks
      • running                   hook=go mod download
      • running                   hook=go mod tidy
   • setting defaults 
      • snapshotting     
      • github/gitlab/gitea releases
      • project name     
      • loading go mod information
      • building binaries
      • creating source archive
      • archives         
      • linux packages   
      • snapcraft packages
      • calculating checksums
      • signing artifacts
      • signing docker images
      • docker images    
      • docker manifests 
      • artifactory      
      • blobs            
      • homebrew tap formula
      • scoop manifests  
      • twitter          
      • milestones       
   • snapshotting     
   • checking ./dist  
      • --rm-dist is set, cleaning it up
   • loading go mod information
   • writing effective config file
      • writing                   config=dist/config.yaml
   • generating changelog
      • writing                   changelog=dist/CHANGELOG.md
   • building binaries
      • building                  binary=/Users/miry/src/github.com/Shopify/toxiproxy/dist/toxiproxy-server-windows-amd64.exe
      • building                  binary=/Users/miry/src/github.com/Shopify/toxiproxy/dist/toxiproxy-server-darwin-amd64
      • building                  binary=/Users/miry/src/github.com/Shopify/toxiproxy/dist/toxiproxy-server-darwin-arm64
      • building                  binary=/Users/miry/src/github.com/Shopify/toxiproxy/dist/toxiproxy-server-freebsd-amd64
      • building                  binary=/Users/miry/src/github.com/Shopify/toxiproxy/dist/toxiproxy-server-solaris-amd64
      • building                  binary=/Users/miry/src/github.com/Shopify/toxiproxy/dist/toxiproxy-server-linux-arm64
      • building                  binary=/Users/miry/src/github.com/Shopify/toxiproxy/dist/toxiproxy-server-freebsd-arm64
      • building                  binary=/Users/miry/src/github.com/Shopify/toxiproxy/dist/toxiproxy-server-openbsd-arm64
      • building                  binary=/Users/miry/src/github.com/Shopify/toxiproxy/dist/toxiproxy-server-linux-amd64
      • building                  binary=/Users/miry/src/github.com/Shopify/toxiproxy/dist/toxiproxy-server-netbsd-amd64
      • building                  binary=/Users/miry/src/github.com/Shopify/toxiproxy/dist/toxiproxy-server-openbsd-amd64
   ⨯ release failed after 34.11s error=template: tmpl:1:37: executing "tmpl" at <.Arm>: map has no entry for key "Arm"

➜  toxiproxy git:(armv6-armv7-builds) ✗ ~/go/bin/goreleaser --version                                       
goreleaser version 0.176.0
commit: dd5ccf7170741e0303e90e81faf9073d03ac8f43
built at: 2021-08-24T23:49:11Z
built by: goreleaser
module version: v0.176.0, checksum: h1:z3hvWAsJCTWS2fmfpbhWYEtIZuxWiwDcq22R2KUZcV8=

https://goreleaser.com

@ghost ghost removed the cla-needed label Nov 7, 2021
@mitchellrj
Copy link
Contributor Author

Thanks for your help, @miry 😁

@miry miry merged commit 3f2973e into Shopify:master Nov 7, 2021
@miry
Copy link
Contributor

miry commented Nov 7, 2021

@mitchellrj Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants