Make it possible to extend list of id types for ActiveRecord relations #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
force-pushed
the
uk-make-id-types-flexible
branch
from
6e3d8c0
to
6fa242f
Compare
bitwise-aiden
approved these changes
Jul 22, 2024
paracycle
force-pushed
the
uk-make-id-types-flexible
branch
from
6fa242f
to
44a79e9
Compare
By moving the list of id types to a constant, we are now making it possible to extend the list of id types for ActiveRecord relations in gem or application level "compilers". All that a "compiler" needs to do is to read the list of id types from the `Tapioca::DSL::Compilers::ActiveRecordRelations::ID_TYPES` constant, add the new id type to the list and then assign the result back to `Tapioca::DSL::Compilers::ActiveRecordRelations::ID_TYPES`.
paracycle
force-pushed
the
uk-make-id-types-flexible
branch
from
44a79e9
to
aeb6eef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes the root problem specified in #1965
Implementation
By moving the list of id types to a constant, we are now making it possible to extend the list of id types for ActiveRecord relations in gem or application level "compilers".
All that a "compiler" needs to do is to read the list of id types from the
Tapioca::DSL::Compilers::ActiveRecordRelations::ID_TYPESconstant, add the new id type to the list and then assign the result back toTapioca::DSL::Compilers::ActiveRecordRelations::ID_TYPES.Tests
Added a DSL CLI test to show how "compilers" can change the behaviour of the AR relations compiler.